<p></p>
<p>Looks good!<br>
A few questions and remarks:</p>
<ul>
<li><code>data/filedefs/filetypes.Meson.conf</code> must be added in <code>data/Makefile.am</code> to <code>filetypes_dist</code>. Otherwise the config file won't be included in releases and won't be installed</li>
<li>it'd be nice if we would add the filetype also to the appropriate key in the<code>[Groups]</code> section in <code>data/filetype_extensions.conf</code> (this is used to place the filetype in the corresponding group in the Document->Set filetype menu) - I'm not sure where it fits best, I guess either in Scripting or Misc</li>
<li>would you mind sorting the keyword and identifiers list alphabetacally? This makes it easier to update in the future</li>
<li>could we maybe use <code>meson.build</code> in <code>data/filetype_extensions.conf</code>? <code>*.build</code> might be too greedy, it seems common to me to use <code>meson.build</code> but I'm no Meson expert :D</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2850#issuecomment-917604664">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5TEAYBGL5ELRXBIQLUBR3MRANCNFSM5AYQOMRA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ4PYRRHSU6QPQCVRIDUBR3MRA5CNFSM5AYQOMRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG2YYSOA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2850#issuecomment-917604664",
"url": "https://github.com/geany/geany/pull/2850#issuecomment-917604664",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>