[Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

Colomban Wendling notifications at xxxxx
Mon Sep 6 22:01:24 UTC 2021


@b4n approved this pull request.

Just tested with Debian Buster's regular g++ (8.3) which works, and ag++ wrapper hack (for it to fail):
```python3
#!/usr/bin/env python3

from os import execvp
from sys import argv

args = ['g++']
for arg in argv[1:]:
	if arg.startswith('-std='):
		continue  # or: arg = '-std=gnu++11'
	args.append(arg)
execvp(args[0], args)
```
And `CXX=/tmp/hack++ ./configure` and it does trigger a failure.

So LGTM if we indeed do need C++17 already.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#pullrequestreview-747431607
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210906/7c1f6201/attachment.htm>


More information about the Github-comments mailing list