<p></p>
<p><b>@b4n</b> approved this pull request.</p>

<p>Just tested with Debian Buster's regular g++ (8.3) which works, and ag++ wrapper hack (for it to fail):</p>
<div class="highlight highlight-source-python"><pre><span class="pl-c">#!/usr/bin/env python3</span>

<span class="pl-k">from</span> <span class="pl-s1">os</span> <span class="pl-k">import</span> <span class="pl-s1">execvp</span>
<span class="pl-k">from</span> <span class="pl-s1">sys</span> <span class="pl-k">import</span> <span class="pl-s1">argv</span>

<span class="pl-s1">args</span> <span class="pl-c1">=</span> [<span class="pl-s">'g++'</span>]
<span class="pl-k">for</span> <span class="pl-s1">arg</span> <span class="pl-c1">in</span> <span class="pl-s1">argv</span>[<span class="pl-c1">1</span>:]:
        <span class="pl-k">if</span> <span class="pl-s1">arg</span>.<span class="pl-en">startswith</span>(<span class="pl-s">'-std='</span>):
                <span class="pl-k">continue</span>  <span class="pl-c"># or: arg = '-std=gnu++11'</span>
        <span class="pl-s1">args</span>.<span class="pl-en">append</span>(<span class="pl-s1">arg</span>)
<span class="pl-en">execvp</span>(<span class="pl-s1">args</span>[<span class="pl-c1">0</span>], <span class="pl-s1">args</span>)</pre></div>
<p>And <code>CXX=/tmp/hack++ ./configure</code> and it does trigger a failure.</p>
<p>So LGTM if we indeed do need C++17 already.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2862#pullrequestreview-747431607">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2S3PFFKXXF2L2EIWDUAU23JANCNFSM5B3CQE6A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ74IVOHE2TCQLAYYNLUAU23JA5CNFSM5B3CQE6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFSGONNY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2862#pullrequestreview-747431607",
"url": "https://github.com/geany/geany/pull/2862#pullrequestreview-747431607",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>