[Github-comments] [geany/geany] Use relative paths for project session files if base directory is relative (PR #3021)

Jiří Techet notifications at xxxxx
Sat Nov 27 17:02:22 UTC 2021


@techee commented on this pull request.



> @@ -1268,6 +1287,16 @@ static gboolean open_session_file(gchar **tmp, guint len)
 	unescaped_filename = g_uri_unescape_string(tmp[7], NULL);
 	locale_filename = utils_get_locale_from_utf8(unescaped_filename);
 
+	if (!g_path_is_absolute(locale_filename) && app->project)

In my opinion the code itself says what it does clearly enough - it doesn't drop any files by itself. The whole logic is preserved as before - if a file from the project isn't found, it just isn't opened. The code here just converts relative paths to absolute paths using project base directory.

And yeah, I guess you know my opinion about adding a config option for every single nonsense by now ;-).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3021#discussion_r757800232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211127/748afcd0/attachment.htm>


More information about the Github-comments mailing list