[Github-comments] [geany/geany] Use strchr instead of strstr (PR #2962)

Avinash Sonawane notifications at xxxxx
Thu Nov 25 07:41:24 UTC 2021


> @rootkea Can you copy/paste the error/warning message from `scan-build` gives? (Since that seems to be the main motivation for this change.)

`scan-build` warned regarding redundant assignment to `pos` in `if` expression (line 1060) since on master we reassign to `pos` at line 1066 without reusing the earlier assigned value.

But now, we are passing the earlier assigned value of `pos` to `strchr()` as you suggested so assignment at line 1060 is no longer redundant.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2962#issuecomment-978914138
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211124/07eb0b95/attachment.htm>


More information about the Github-comments mailing list