<p></p>
<blockquote>
<p dir="auto"><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/rootkea/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rootkea">@rootkea</a> Can you copy/paste the error/warning message from <code>scan-build</code> gives? (Since that seems to be the main motivation for this change.)</p>
</blockquote>
<p dir="auto"><code>scan-build</code> warned regarding redundant assignment to <code>pos</code> in <code>if</code> expression (line 1060) since on master we reassign to <code>pos</code> at line 1066 without reusing the earlier assigned value.</p>
<p dir="auto">But now, we are passing the earlier assigned value of <code>pos</code> to <code>strchr()</code> as you suggested so assignment at line 1060 is no longer redundant.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2962#issuecomment-978914138">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4ET4OH6KMCUSCOGYDUNXSCJANCNFSM5G2EQTXA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ7CYXRTWSN5A7QCRCLUNXSCJA5CNFSM5G2EQTXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHJMQWWQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2962#issuecomment-978914138",
"url": "https://github.com/geany/geany/pull/2962#issuecomment-978914138",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>