[Github-comments] [geany/geany] Use dark-theme friendly colors for compiler messages (PR #3013)

elextr notifications at xxxxx
Tue Nov 23 12:44:43 UTC 2021


> It's also difficult to get 2, 3, and 4 to all be different for both protanopea and deuteranopia.

Yes, thats why the colours need to be such that they will contrast to both dark and light backgrounds but not generate artefacts, so they are legible even if the colour can't be perceived.  Unfortunately mid range themes will likely need adjustment, but thats why we have geany.css, we can never make everybody happy.

(1) agreed.

(2) happy to shuffle the deckchair to @xiota's `#309030`

(3) @xiota's suggestion of `#ee8000` is ok for me.

(4) `#ff3030` seems to be accepted. @techee I thought that the error squiggle used this CSS setting already?  Looks like it to me but I didn't check the code.

> Based on the proposed uses, it seems more important to distinguish 4 from 2/3 than to distinguish 2 and 3 from each other.

Correct.

(3) and (4) need to be distinguishable since they show in the same compiler message window, but the lines coloured (4) are clickable and those coloured (3) are not.  For simple languages like C its pretty obvious which are clickable, but guess which ones are clickable in [this single error message](https://gist.github.com/elextr/0cea1225e322a499af234f4e4a54b54a) from the C++ file I have been using for testing of the compiler colours.

> But seriously, in the next release nobody will notice Scintilla 5, updated ctags, meson build, etc., but everybody will see the color changes made here so better not to screw up much.

Sadly you are very much correct :stuck_out_tongue_winking_eye:   

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3013#issuecomment-976477226
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211123/935a4130/attachment.htm>


More information about the Github-comments mailing list