[Github-comments] [geany/geany] fix compilation with clang on Windows (PR #3067)

Rosen Penev notifications at xxxxx
Fri Dec 24 02:27:39 UTC 2021


clang on Windows throws -Wdll-attribute-on-declaration. It expects
dllexport to be done on the first declaration.

Make use of G_MODULE_EXPORT instead of custom solution as GTK is a
requirement.

Signed-off-by: Rosen Penev <rosenp at gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3067

-- Commit Summary --

  * fix compilation with clang on Windows

-- File Changes --

    M scintilla/gtk/ScintillaGTK.cxx (7)
    M scintilla/include/ScintillaWidget.h (18)
    M src/build.h (5)
    M src/dialogs.c (2)
    M src/dialogs.h (5)
    M src/document.h (26)
    M src/editor.c (3)
    M src/editor.h (17)
    M src/encodings.h (3)
    M src/filetypes.h (6)
    M src/geanyobject.h (2)
    M src/highlighting.h (5)
    M src/keybindings.h (6)
    M src/main.h (4)
    M src/msgwindow.h (9)
    M src/navqueue.h (1)
    M src/plugindata.h (6)
    M src/pluginutils.h (14)
    M src/project.h (2)
    M src/sciwrappers.h (52)
    M src/search.h (2)
    M src/spawn.h (7)
    M src/stash.h (21)
    M src/symbols.h (1)
    M src/templates.h (1)
    M src/ui_utils.h (21)
    M src/utils.h (27)

-- Patch Links --

https://github.com/geany/geany/pull/3067.patch
https://github.com/geany/geany/pull/3067.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3067
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3067 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211223/bc2bfabe/attachment-0001.htm>


More information about the Github-comments mailing list