<p dir="auto">clang on Windows throws -Wdll-attribute-on-declaration. It expects<br>
dllexport to be done on the first declaration.</p>
<p dir="auto">Make use of G_MODULE_EXPORT instead of custom solution as GTK is a<br>
requirement.</p>
<p dir="auto">Signed-off-by: Rosen Penev <a href="mailto:rosenp@gmail.com">rosenp@gmail.com</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/geany/geany/pull/3067'>https://github.com/geany/geany/pull/3067</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/geany/geany/pull/3067/commits/83c9226fedb08f5337a81f8d6ac4b1d72733ccb9" class="commit-link">83c9226</a> fix compilation with clang on Windows</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/geany/geany/pull/3067/files">27 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-8457be7d3164ace017d2c570b601d2111e730b52e8a4786ed91518adba22e641">scintilla/gtk/ScintillaGTK.cxx</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-3cb0a69216f6d5c87f596d3b8b2e6b830e285a31115302cc4a7d3a6653f4ac53">scintilla/include/ScintillaWidget.h</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-4f21380c092452e08071371e6029bc48baed6b08459986b53283b6b0f63ff9cc">src/build.h</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-eeef27d5cc6a3ec5a0bb0cf15d8a7af0fb3c3c1df95d5773e23616a6de85a2e4">src/dialogs.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-200da6547ac66cb55b3eebfa190e8fd73aaeb01f33802d48295f4a814cfb620d">src/dialogs.h</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-c87d179e64256ec59ec084895132708cf6c917dd1ff722c66b71e4f6235b7634">src/document.h</a>
(26)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-3fe5ce523684a7fca311fab0d09542552fbe3a28ddaa20ebc5a65c1904bc5e02">src/editor.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-250599d8188c89a855e09814adc59505f6e5d31cc234a9e085f706f3b314644b">src/editor.h</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-aba4475c8875c32e7f1a8454eba0e8989b68accb65660e85abcd1bef5245b1c8">src/encodings.h</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-fd6ee82c0ffe1e8575dbad58dbb7a9b1303b68e2664da4a624515093f2d17178">src/filetypes.h</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-ce8ab6d19ecbee3495a94f4fc5b3717401abe07129f14daab8aa03e8fd44d29f">src/geanyobject.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-5f00545f1831fb208e8ba611a4cb1792d3137da1253974be3c2027e2d5068427">src/highlighting.h</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-ce7d99c36f7f5be03d0e4a0415e48777ecae42105f0a84069f8fa21dc99d31a3">src/keybindings.h</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-910d89612d74e91ae70ed40289b3910b1c1a09b1f5a1bb0b15849f70760cbba2">src/main.h</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-58c572e4f194db9c00baec4186dac18ee9fba702d4e9d428cce7867fc4fdfee7">src/msgwindow.h</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-29acfa15fad4a86aa93daa6c0a3ed82fdb7211c8405a47d0ffa9df3d2d73170f">src/navqueue.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-4316f93b38ec68bc3ee98a1ff6a08db0164f9baad6b3b2403909064202cc8fcc">src/plugindata.h</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-8f741625f1114aecbe9a4791da5ffbbc09ce27cdbed8b1dc677cd70bd313a879">src/pluginutils.h</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-160027d71936304387f551d0509e48292eab3429e467ec097ad56f80e2ebb544">src/project.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-56ae82f66618f1c432ca3bb896373541d46a5867bfd3524c8b36da3cdc502419">src/sciwrappers.h</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-deeffa8191944369a8d33872f33d3163a8274ad8fa767b2a9c04c262f7d1cee6">src/search.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-437d17830b42c1db3e1f90f251711a69ebbfe39448287549bf81f40ad320a2ae">src/spawn.h</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-0c9dc9d7e85e6ac35bdb7fdc99ece8330a38a45c3c7848617968c6b47aea3fc6">src/stash.h</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-36d2bce56006ae4b4dfa657333e462de31b3d3da032ba5bd4cdeb9aef5cdc3a0">src/symbols.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-2761b4b88e9cec920aeef275a02af3a75a4bd6ad40205c24e90b66b9ea8ce021">src/templates.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-c5e507f1f38d770eac7b5a9c906195bdebc43bb064ed4b6af981cdce102f14ff">src/ui_utils.h</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3067/files#diff-9022459f0ccbb7cf6daac6ecb5af4f37d240219981a8c23076c14c5f002f9c8c">src/utils.h</a>
(27)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/geany/geany/pull/3067.patch'>https://github.com/geany/geany/pull/3067.patch</a></li>
<li><a href='https://github.com/geany/geany/pull/3067.diff'>https://github.com/geany/geany/pull/3067.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3067">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ62G4SUMARDZZC7UUDUSPLBXANCNFSM5KV3NYOA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ3DQWK7MERAR6HGHKDUSPLBXA5CNFSM5KV3NYOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4QG3DRLQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3067</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3067",
"url": "https://github.com/geany/geany/pull/3067",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>