[Github-comments] [geany/geany] Update to Scintilla 4.x (#2519)

[Thomas Martitz]

Yeah, I know the update script. I'm not concerned about the repository size t.b.h. geany is so tiny compared to everything else I usually work with and adding a few more files is not going to change that drastically. Git is pretty good at storing only actual changes.

I'm more worried about a) not detecting file deletions upstream and b) new stuff in files that we don't update. Also, in my eyes the existing script is more fragile than a plain `git merge` even though it has worked well in the past. In fact, the script I added just imports raw upstream scintilla into a side branch. Integrating that into master is not scripted because it's a plain merge.

But the most important selling point for me is that we can make changes directly to scintilla and have them automatically preserved when importing a new version without messing with a patch file.

I'll open a new PR for further discussion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2519#issuecomment-700179510
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20200928/180a19ea/attachment.htm>