[Github-comments] [geany/geany] Create project's filename path (#2586)

[Matthew Brush]

@codebrainz requested changes on this pull request.

I just a did a quick skim of the diff, not a full review.

> @@ -772,6 +772,53 @@ static gboolean update_config(const PropertyDialogElements *e, gboolean new_proj
 		}
 		g_free(locale_path);
 	}
+
+	/* create filename path if it doesn't exist */
+	if ((err_code = utils_is_file_writable(locale_filename)) != 0) {

Should follow the style of the other code with respect to braces. There's some style info in the [`HACKING` file](https://github.com/geany/geany/blob/55e0998c3b131e8febe118245778702e65d4086f/HACKING#L271).

> +
+			create_dir = dialogs_show_question_full(NULL, GTK_STOCK_OK, GTK_STOCK_CANCEL,
+				_("Create the project's filename path directory?"),
+				_("The path \"%s\" does not exist."),
+				filename_path);
+
+			if (create_dir) {
+				err_code = utils_mkdir(filename_path, TRUE);
+				g_free(filename_path);
+				if (err_code != 0) {
+					SHOW_ERR1(_("Filename path could not be created (%s)."),
+						g_strerror(err_code));
+					return FALSE;
+				}
+			}
+		}

It looks like `filename_path` is leaked when this brace is reached if the `if (create_dir)` branch above isn't taken.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2586#pullrequestreview-488256295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20200914/fcfd59c0/attachment.htm>