<p></p>
<p><b>@codebrainz</b> requested changes on this pull request.</p>

<p>I just a did a quick skim of the diff, not a full review.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2586#discussion_r488323935">src/project.c</a>:</p>
<pre style='color:#555'>> @@ -772,6 +772,53 @@ static gboolean update_config(const PropertyDialogElements *e, gboolean new_proj
                }
                g_free(locale_path);
        }
+
+       /* create filename path if it doesn't exist */
+       if ((err_code = utils_is_file_writable(locale_filename)) != 0) {
</pre>
<p>Should follow the style of the other code with respect to braces. There's some style info in the <a href="https://github.com/geany/geany/blob/55e0998c3b131e8febe118245778702e65d4086f/HACKING#L271"><code>HACKING</code> file</a>.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2586#discussion_r488324400">src/project.c</a>:</p>
<pre style='color:#555'>> +
+                       create_dir = dialogs_show_question_full(NULL, GTK_STOCK_OK, GTK_STOCK_CANCEL,
+                               _("Create the project's filename path directory?"),
+                               _("The path \"%s\" does not exist."),
+                               filename_path);
+
+                       if (create_dir) {
+                               err_code = utils_mkdir(filename_path, TRUE);
+                               g_free(filename_path);
+                               if (err_code != 0) {
+                                       SHOW_ERR1(_("Filename path could not be created (%s)."),
+                                               g_strerror(err_code));
+                                       return FALSE;
+                               }
+                       }
+               }
</pre>
<p>It looks like <code>filename_path</code> is leaked when this brace is reached if the <code>if (create_dir)</code> branch above isn't taken.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2586#pullrequestreview-488256295">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZPPCVRFRYP6YCDAOTSF26HBANCNFSM4RLUS2GA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ67LGWLJDCTAMSZHMTSF26HBA5CNFSM4RLUS2GKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODUNDGJY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2586#pullrequestreview-488256295",
"url": "https://github.com/geany/geany/pull/2586#pullrequestreview-488256295",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>