[Github-comments] [geany/geany-plugins] Debugger: Fix cppcheck false positive warning (#1017)

Colomban Wendling notifications at xxxxx
Fri Oct 23 09:31:53 UTC 2020


@b4n commented on this pull request.



> @@ -265,11 +264,9 @@ void tpage_pack_widgets(gboolean tabbed)
 
 	if (oldroot)
 	{
-		int i = 0;
-		while (widgets[i])
+		for (int i = 0; widgets[i]; i++)
 		{
 			g_object_unref(*widgets[i]);

Is cppcheck happy with that?  Actually I'm still confused on what it didn't like before, so maybe it's happy. It's correct anyway so whichever way's OK with me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1017#pullrequestreview-515500152
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201023/72e4fa8c/attachment.htm>


More information about the Github-comments mailing list