[Github-comments] [geany/geany-plugins] Debugger: Fix cppcheck false positive warning (#1017)

Colomban Wendling notifications at xxxxx
Fri Oct 23 09:30:49 UTC 2020


@b4n commented on this pull request.



> @@ -142,19 +142,18 @@ void tpage_pack_widgets(gboolean tabbed)
 	GList *children = gtk_container_get_children(GTK_CONTAINER(tab_target));
 	if (children)
 	{
-		int i;
-
-		oldroot = (GtkWidget*)children->data;
+		GtkWidget **widget_ref = NULL;

I'd rather have this declared in the loop

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1017#pullrequestreview-515499351
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201023/fd08fb26/attachment.htm>


More information about the Github-comments mailing list