[Github-comments] [geany/geany] OS Info Improvements (#2618)

[elextr]

@elextr requested changes on this pull request.

Also making the strings untranslated makes it mergable now we are in string freeze :)

> +# endif
+#else
+	/* if g_get_os_info() is not available, do it the old-fashioned way */
+# if defined(_WIN64)
+	os_info = g_strdup(_("Microsoft Windows (64-bit)"));
+# elif defined(_WIN32)
+	os_info = g_strdup(_("Microsoft Windows"));
+# elif defined(__APPLE__)
+	os_info = g_strdup(_("Apple macOS"));
+# elif defined(__linux__)
+	os_info = g_strdup(_("Linux"));
+# elif defined(__FreeBSD__)
+	os_info = g_strdup(_("FreeBSD"));
+# elif defined(__ANDROID__)
+	os_info = g_strdup(_("Android"));
+# endif

Why are the above marked as translatable, what we want is the OS name, and all of them are English.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2618#pullrequestreview-506969466
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201012/174bb7ef/attachment.htm>