[Github-comments] [geany/geany] Ctags sync rebased (#2666)

[Enrico Tröger]

> > The good news is: without the --strip-trailing-cr change, the binary mode actually fixes all the tests except the six failures.
> 
> Great! I think changing the mode to binary is such a trivial change that I could addd it as a commit to this pull request, what do you think?

Sure, why not.
 
> > The six failures can be fixed easily by converting the test samples to LF, however.
> 
> Yeah, but it should still be fixed. This could possibly mean that any file using CRLF, which is the default EOL on Windows, would get tags generated incorrectly so they may not appear in the symbol tree. Have you tried e.g. some C file with CRLFs, if the tags show up in the sidebar?

No, the line endings of the input files don't matter. Tested with a C and SQL file (random choice) with LF and then again with CRLF line endings and the generated tags are the same.
With the binary mode change we would also alte rthe behavior when writing tags files which then always contain only LF. I think this is fine even on Windows.
And so we just need to update the six test samples which have CRLF line endings (in contrary to all other test samples).


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-735468189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201129/7ad7fe38/attachment-0001.htm>