[Github-comments] [geany/geany] Ctags sync rebased (#2666)

Jiří Techet notifications at xxxxx
Sun Nov 29 17:43:23 UTC 2020


> The good news is: without the --strip-trailing-cr change, the binary mode actually fixes all the tests except the six failures. 

Great! I think changing the mode to binary is such a trivial change that I could addd it as a commit to this pull request, what do you think?

> The six failures can be fixed easily by converting the test samples to LF, however.

Yeah, but it should still be fixed. This could possibly mean that any file using CRLF, which is the default EOL on Windows, would get tags generated incorrectly so they may not appear in the symbol tree. Have you tried e.g. some C file with CRLFs, if the tags show up in the sidebar?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-735429973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201129/addb9a60/attachment.htm>


More information about the Github-comments mailing list