[Github-comments] [geany/geany] Ctags sync rebased (#2666)

Enrico Tröger notifications at xxxxx
Sat Nov 28 14:59:37 UTC 2020


> @eht16 Just curious, do you run `make check` when you make Windows releases?

No, I don't. I just ran the checks now with this PR as I thought it might help.
The tests fail in the same way for Geany master, so you are absolutely right: it's not new and not related to this PR.
Sorry, I should have mentioned this.


>     1. Would you try opening the file in binary mode and check what tests fail when you do?

No change.

 
>     2. Would you try changing CRLF line ends in the SQL tests that fail to LF to see if this is the reason for the problem? I checked uctags implementation of file reading and CRLF should be handled there correctly so it could be something parser-specific.

This actually helps. I converted the test files of the six failures to LF and the tests passed fine.

So I think we should address this separately, maybe after this PR got merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-735241106
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201128/e5cc9d11/attachment.htm>


More information about the Github-comments mailing list