<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eht16/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> Just curious, do you run <code>make check</code> when you make Windows releases?</p>
</blockquote>
<p>No, I don't. I just ran the checks now with this PR as I thought it might help.<br>
The tests fail in the same way for Geany master, so you are absolutely right: it's not new and not related to this PR.<br>
Sorry, I should have mentioned this.</p>
<blockquote>
<pre><code>1. Would you try opening the file in binary mode and check what tests fail when you do?
</code></pre>
</blockquote>
<p>No change.</p>
<blockquote>
<pre><code>2. Would you try changing CRLF line ends in the SQL tests that fail to LF to see if this is the reason for the problem? I checked uctags implementation of file reading and CRLF should be handled there correctly so it could be something parser-specific.
</code></pre>
</blockquote>
<p>This actually helps. I converted the test files of the six failures to LF and the tests passed fine.</p>
<p>So I think we should address this separately, maybe after this PR got merged.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2666#issuecomment-735241106">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ42URAIFLAP5F6RPXDSSEF5TANCNFSM4T2VTWXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ7WV5PDRGI7CW3DMUTSSEF5TA5CNFSM4T2VTWXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFPJOHEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2666#issuecomment-735241106",
"url": "https://github.com/geany/geany/pull/2666#issuecomment-735241106",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>