[Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

[Enrico Tröger]

@eht16 commented on this pull request.



> @@ -1,43 +1,51 @@
-#!/bin/sh
+#!/bin/bash

There are a couple of `$(command...)` in there even though I might added them after I set it to bash :+1: 
The reason is this way we don't need to care whether to use bashisms or not. And shell portability isn't an issue for this particular script. It is used in a Docker container where bash is always available (as defined by Dockerfile) or it is used on MSYS2 where bash is an essential package.
So we just make our own life easier. I'm a big fan of portable scripts but here it would be simply overkill.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2590#discussion_r519184616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201107/162b80f3/attachment.htm>