<p></p>
<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2590#discussion_r519184616">scripts/gtk-bundle-from-msys2.sh</a>:</p>
<pre style='color:#555'>> @@ -1,43 +1,51 @@
-#!/bin/sh
+#!/bin/bash
</pre>
<p>There are a couple of <code>$(command...)</code> in there even though I might added them after I set it to bash <g-emoji class="g-emoji" alias="+1" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji><br>
The reason is this way we don't need to care whether to use bashisms or not. And shell portability isn't an issue for this particular script. It is used in a Docker container where bash is always available (as defined by Dockerfile) or it is used on MSYS2 where bash is an essential package.<br>
So we just make our own life easier. I'm a big fan of portable scripts but here it would be simply overkill.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2590#discussion_r519184616">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJY45GAEXZR4NF3N7TLSOVMV5ANCNFSM4RTUWQYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJYONYNRFDTGMYNRB6TSOVMV5A5CNFSM4RTUWQYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD5KONHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2590#discussion_r519184616",
"url": "https://github.com/geany/geany/pull/2590#discussion_r519184616",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>