[Github-comments] [geany/geany] added a bibtex parser that extracts identifiers of entries in bib-fil… (#2212)

[Matthew Brush]

codebrainz requested changes on this pull request.

Aside from the enumerator order, this looks like it's relatively safe and clean change.

If nobody objects, I'll try and get this merged in a few weeks.

> @@ -74,6 +74,7 @@ typedef enum
 	GEANY_FILETYPES_VALA,
 	GEANY_FILETYPES_PASCAL,
 	GEANY_FILETYPES_LATEX,
+	GEANY_FILETYPES_BIBTEX,

This needs to move to the end where it says `/* ^ append items here */` to preserve the ABI.

> @@ -67,6 +67,7 @@ enum
 	TM_PARSER_PHP,
 	TM_PARSER_PYTHON,
 	TM_PARSER_LATEX,
+	TM_PARSER_BIBTEX,

Not sure this is in the plugin API, but it might be better to put at end before `TM_PARSER_COUNT` anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2212#pullrequestreview-290275690
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190918/5808ab8a/attachment-0001.html>