<p><b>@codebrainz</b> requested changes on this pull request.</p>

<p>Aside from the enumerator order, this looks like it's relatively safe and clean change.</p>
<p>If nobody objects, I'll try and get this merged in a few weeks.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2212#discussion_r325951839">src/filetypes.h</a>:</p>
<pre style='color:#555'>> @@ -74,6 +74,7 @@ typedef enum
        GEANY_FILETYPES_VALA,
        GEANY_FILETYPES_PASCAL,
        GEANY_FILETYPES_LATEX,
+       GEANY_FILETYPES_BIBTEX,
</pre>
<p>This needs to move to the end where it says <code>/* ^ append items here */</code> to preserve the ABI.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2212#discussion_r325952069">src/tagmanager/tm_parser.h</a>:</p>
<pre style='color:#555'>> @@ -67,6 +67,7 @@ enum
        TM_PARSER_PHP,
        TM_PARSER_PYTHON,
        TM_PARSER_LATEX,
+       TM_PARSER_BIBTEX,
</pre>
<p>Not sure this is in the plugin API, but it might be better to put at end before <code>TM_PARSER_COUNT</code> anyway.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2212?email_source=notifications&email_token=AAIOWJ4UGWL4RAJHUCWWBCLQKLFONA5CNFSM4H7MF7RKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFGUC2Q#pullrequestreview-290275690">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7NZZGODTFMMGIAPGLQKLFONANCNFSM4H7MF7RA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5JJAF3D47ECXZUBEDQKLFONA5CNFSM4H7MF7RKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFGUC2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2212?email_source=notifications\u0026email_token=AAIOWJ4UGWL4RAJHUCWWBCLQKLFONA5CNFSM4H7MF7RKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFGUC2Q#pullrequestreview-290275690",
"url": "https://github.com/geany/geany/pull/2212?email_source=notifications\u0026email_token=AAIOWJ4UGWL4RAJHUCWWBCLQKLFONA5CNFSM4H7MF7RKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFGUC2Q#pullrequestreview-290275690",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>