[Github-comments] [geany/geany] Multi-line "Find in Files" searching (#2322)

[Nick Treleaven]

> It almost works, but I had to tweak the code:

Ok, thanks. Looks good, I didn't realize pcregrep doesn't have an -E option.

> The only other remark is the exclude-dir and exclude and include syntax works via regexps not globbing 

Hmm, it's frustrating that they repurposed those options, it's so close to being a drop in replacement. (They could have added regexp file matching with different option names). We could just disable the file filter row when pcregrep is set.

> As for whether we should use grep...
> I don't see why it would be hard to do this internally though, given that Geany already implements regexp searching of files

It doesn't. Geany loads files into scintilla. It would be simple to implement trivial file searching, but grep and pcregrep have many optimisations vs simple linear search and reading entire files into buffers.

> Possibly people are using some exotic options

Yes, I expect we would struggle with this. For example, pcregrep has an option to treat lone CR or LF as a new line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2322#issuecomment-541607910
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191014/ba2246c8/attachment.html>