[Github-comments] [geany/geany] Multi-line "Find in Files" searching (#2322)

[Chris Graham]

> I think you could already set pcregrep as the grep tool in Preferences. Then in the other options entry [of find in files] you can add any necessary flags for multi-line matching.

Thanks, I wasn't aware of the option. It almost works, but I had to tweak the code:
https://github.com/chrisgraham/geany/commit/bff6c99db915375474d1d0327e24ba6156ac4367
(maybe someone would like to merge this change if it looks okay?)

The only other remark is the exclude-dir an exclude and include syntax works via regexps not globbing (which is nicer IMO). So the user will need to change how they fill in the custom files filter, and their extra options.

As for whether we should use grep... I can see both sides of it, especially knowing I now can use pcregrep. I don't see why it would be hard to do this internally though, given that Geany already implements regexp searching of files. What's the big difference if it can do what it already does enumerating over a project directory? Possibly people are using some exotic options. For me, all I do is specify what directories/files to exclude, which already is a project property.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2322#issuecomment-541441736
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191013/16861449/attachment-0001.html>