[Github-comments] [geany/geany] Show zoom level in status bar. (#1697)

[Colomban Wendling]

b4n requested changes on this pull request.

Apart from that function name and using fractional sizes, looks pretty good to me.

> +gint sci_get_fontsize(ScintillaObject *sci, gint style)
+{
+	return (gint) SSM(sci, SCI_STYLEGETSIZE, (uptr_t) style, 0);
+}

I would still like to see the function renamed with an underscore between `font` and `size`.

Also, we now are using [SCI_STYLESETSIZEFRACTIONAL](https://scintilla.org/ScintillaDoc.html#SCI_STYLESETSIZEFRACTIONAL), so this should probably be using fractional sizes as well and return a `gdouble`.

Something like that (untested)
```c
gdouble sci_get_font_size(ScintillaObject *sci, gint style)
{
	return SSM(sci, SCI_STYLEGETSIZEFRACTIONAL, (uptr_t) style, 0) / (gdouble) SC_FONT_SIZE_MULTIPLIER;
}
```

> @@ -218,6 +219,8 @@ void				sci_move_selected_lines_up      (ScintillaObject *sci);
 
 void				sci_set_font_fractional		(ScintillaObject *sci, gint style, const gchar *font, gdouble size);
 
+gint				sci_get_fontsize			(ScintillaObject *sci, gint style);

Rename to `sci_get_font_size()` here as well

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#pullrequestreview-297410588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191004/9df20f5e/attachment.html>