<p><b>@b4n</b> requested changes on this pull request.</p>

<p>Apart from that function name and using fractional sizes, looks pretty good to me.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1697#discussion_r331453645">src/sciwrappers.c</a>:</p>
<pre style='color:#555'>> +gint sci_get_fontsize(ScintillaObject *sci, gint style)
+{
+       return (gint) SSM(sci, SCI_STYLEGETSIZE, (uptr_t) style, 0);
+}
</pre>
<p>I would still like to see the function renamed with an underscore between <code>font</code> and <code>size</code>.</p>
<p>Also, we now are using <a href="https://scintilla.org/ScintillaDoc.html#SCI_STYLESETSIZEFRACTIONAL" rel="nofollow">SCI_STYLESETSIZEFRACTIONAL</a>, so this should probably be using fractional sizes as well and return a <code>gdouble</code>.</p>
<p>Something like that (untested)</p>
<div class="highlight highlight-source-c"><pre>gdouble <span class="pl-en">sci_get_font_size</span>(ScintillaObject *sci, gint style)
{
        <span class="pl-k">return</span> <span class="pl-c1">SSM</span>(sci, SCI_STYLEGETSIZEFRACTIONAL, (<span class="pl-c1">uptr_t</span>) style, <span class="pl-c1">0</span>) / (gdouble) SC_FONT_SIZE_MULTIPLIER;
}</pre></div>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1697#discussion_r331453819">src/sciwrappers.h</a>:</p>
<pre style='color:#555'>> @@ -218,6 +219,8 @@ void                             sci_move_selected_lines_up      (ScintillaObject *sci);
 
 void                           sci_set_font_fractional         (ScintillaObject *sci, gint style, const gchar *font, gdouble size);
 
+gint                           sci_get_fontsize                        (ScintillaObject *sci, gint style);
</pre>
<p>Rename to <code>sci_get_font_size()</code> here as well</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1697?email_source=notifications&email_token=AAIOWJ2SAD4IO64IKBWHZM3QM4RTVA5CNFSM4EFEY7TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG5CAHA#pullrequestreview-297410588">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7RG4Q2NBXFSIKPQBDQM4RTVANCNFSM4EFEY7TA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ54PCEQHNY4BUEHRTTQM4RTVA5CNFSM4EFEY7TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG5CAHA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1697?email_source=notifications\u0026email_token=AAIOWJ2SAD4IO64IKBWHZM3QM4RTVA5CNFSM4EFEY7TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG5CAHA#pullrequestreview-297410588",
"url": "https://github.com/geany/geany/pull/1697?email_source=notifications\u0026email_token=AAIOWJ2SAD4IO64IKBWHZM3QM4RTVA5CNFSM4EFEY7TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG5CAHA#pullrequestreview-297410588",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>