[Github-comments] [geany/geany-plugins] lipsum: fixed deprecated gtk call for gtk3 (#856)

[LarsGit223]

LarsGit223 commented on this pull request.



> @@ -51,6 +51,14 @@ G_BEGIN_DECLS
 #define GTK_STOCK_OPEN   _("_Open")
 #define GTK_STOCK_CANCEL _("_Cancel")
 #endif
+
+/* Replace calls to gtk_image_menu_item_new_with_mnemonic() with call to
+   gtk_menu_item_new_with_mnemonic(). Starting from version 3.10.*/
+#if GTK_CHECK_VERSION(3, 10, 0)
+#define gtk_image_menu_item_new_with_mnemonic(icon_info) \
+        gtk_menu_item_new_with_mnemonic(icon_info)

Thanks. But I guess I will then postpone that to a later time when it's really required. Here with lipsum there is no icon used at all. I will do the replacement in the lipsum file directly and remove the macro. If I find a use case later which really uses an icon I will go for your advice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/856#discussion_r283187805
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190512/a54bb480/attachment.html>