[Github-comments] [geany/geany-plugins] lipsum: fixed deprecated gtk call for gtk3 (#856)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -51,6 +51,14 @@ G_BEGIN_DECLS
 #define GTK_STOCK_OPEN   _("_Open")
 #define GTK_STOCK_CANCEL _("_Cancel")
 #endif
+
+/* Replace calls to gtk_image_menu_item_new_with_mnemonic() with call to
+   gtk_menu_item_new_with_mnemonic(). Starting from version 3.10.*/
+#if GTK_CHECK_VERSION(3, 10, 0)
+#define gtk_image_menu_item_new_with_mnemonic(icon_info) \
+        gtk_menu_item_new_with_mnemonic(icon_info)

This doesn't seem like a good wrapper for general use in the util library since it returns a different type of widget.

While much more work, it might be better to add some kind of real image menu item replacement class that packs an optional icon and an accel label into a box, similar to the example on the [GtkImageMenuItem docs](https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/856#pullrequestreview-236439122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190512/c433a629/attachment.html>