[Github-comments] [geany/geany] Remember search history (#1666) (#1745)

johndescs notifications at xxxxx
Tue Mar 5 12:00:31 UTC 2019


Just tested this right now. Works well for me.
I've still spotted an issue in that the history is filled in a strange order (seems to be once last item, then first, then last and so on?!). Probably not related to this patch but, since it is now beeing saved, the history will sooner or later be full (and keep beeing full forever) and this strange order has the side effect of deleting an item that is not necessarily the older when inserting a new oneā€¦ which is not good.
About infinite growth, yes it seems currently clamped by the combobox history mechanism, but I second the fear of elextr: should it really rely on some external UI stuff that may change / break anytime later to be safe on Geany side?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1745#issuecomment-469654382
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190305/19e7b99b/attachment.html>


More information about the Github-comments mailing list