<p>Just tested this right now. Works well for me.<br>
I've still spotted an issue in that the history is filled in a strange order (seems to be once last item, then first, then last and so on?!). Probably not related to this patch but, since it is now beeing saved, the history will sooner or later be full (and keep beeing full forever) and this strange order has the side effect of deleting an item that is not necessarily the older when inserting a new one… which is not good.<br>
About infinite growth, yes it seems currently clamped by the combobox history mechanism, but I second the fear of elextr: should it really rely on some external UI stuff that may change / break anytime later to be safe on Geany side?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1745#issuecomment-469654382">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxOEAgh-9Ak5JRxneGxtUz2_QCyJks5vTlxfgaJpZM4Rk8q8">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJy1F2NaEqP3xjwvKjxLxaoRanG1Nks5vTlxfgaJpZM4Rk8q8.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@johndescs in #1745: Just tested this right now. Works well for me.\r\nI've still spotted an issue in that the history is filled in a strange order (seems to be once last item, then first, then last and so on?!). Probably not related to this patch but, since it is now beeing saved, the history will sooner or later be full (and keep beeing full forever) and this strange order has the side effect of deleting an item that is not necessarily the older when inserting a new one… which is not good.\r\nAbout infinite growth, yes it seems currently clamped by the combobox history mechanism, but I second the fear of elextr: should it really rely on some external UI stuff that may change / break anytime later to be safe on Geany side?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1745#issuecomment-469654382"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1745#issuecomment-469654382",
"url": "https://github.com/geany/geany/pull/1745#issuecomment-469654382",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>