[Github-comments] [geany/geany] extra-custom-distro snippets support #1859 (#1866)

[johndescs]

johndescs requested changes on this pull request.

I'm not a Geany dev, but I'm not sure why this behaviour would be desirable. Since Geany already has a mechanism for the users to override the default snippets, one would expect the packager to use the tools of their package-building system to change the file directly in-place (for example, Quilt, which would keep a patch and ensure that it applies correctly when upstream changes are made).

> @@ -149,6 +149,39 @@ static void snippets_load(GKeyFile *sysconfig, GKeyFile *userconfig)
 	}
 	g_strfreev(groups_sys);
 
+	/* now read defined completions in DISTRO's configuration directory and add / replace them */

This duplicates a lot of code.

> @@ -4748,10 +4791,6 @@ on_editor_scroll_event(GtkWidget *widget, GdkEventScroll *event, gpointer user_d
 {
 	GeanyEditor *editor = user_data;
 
-	/* we only handle up and down, leave the rest to Scintilla */

What's the point of this? Maybe belongs to some other modification set?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1866#pullrequestreview-210611106
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190305/82eba35d/attachment.html>