<p><b>@johndescs</b> requested changes on this pull request.</p>

<p>I'm not a Geany dev, but I'm not sure why this behaviour would be desirable. Since Geany already has a mechanism for the users to override the default snippets, one would expect the packager to use the tools of their package-building system to change the file directly in-place (for example, Quilt, which would keep a patch and ensure that it applies correctly when upstream changes are made).</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1866#discussion_r262442870">src/editor.c</a>:</p>
<pre style='color:#555'>> @@ -149,6 +149,39 @@ static void snippets_load(GKeyFile *sysconfig, GKeyFile *userconfig)
        }
        g_strfreev(groups_sys);
 
+       /* now read defined completions in DISTRO's configuration directory and add / replace them */
</pre>
<p>This duplicates a lot of code.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1866#discussion_r262443199">src/editor.c</a>:</p>
<pre style='color:#555'>> @@ -4748,10 +4791,6 @@ on_editor_scroll_event(GtkWidget *widget, GdkEventScroll *event, gpointer user_d
 {
        GeanyEditor *editor = user_data;
 
-       /* we only handle up and down, leave the rest to Scintilla */
</pre>
<p>What's the point of this? Maybe belongs to some other modification set?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1866#pullrequestreview-210611106">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9gpEFWbpBkf5BHmXpDnMlWujbgbks5vTk1XgaJpZM4USKCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ8jGkv9ANGK350cDNMwCMve8K8V5ks5vTk1XgaJpZM4USKCA.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@johndescs requested changes on #1866"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1866#pullrequestreview-210611106"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1866#pullrequestreview-210611106",
"url": "https://github.com/geany/geany/pull/1866#pullrequestreview-210611106",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>