[Github-comments] [geany/geany] NSIS upgrade to 3.x (#2181)

[Enrico Tröger]

eht16 commented on this pull request.



> @@ -39,8 +39,7 @@ variables=$(\
 variables_extra='{nsisdir} 0 1 2 3 4 5 6 7 8 9 r0 r1 r2 r3 r4 r5 r6 r7 r8 r9 \\n \\r \\t $'
 variables="${variables_extra} ${variables}"
 # prefix each element with a dollar sign
-declare -a variables_array=(${variables})
-variables="${variables_array[@]/#/'$'}"
+variables="$(echo $variables | sed 's/[^ ]*/$&/g')"

There were, of course.
Removed in https://github.com/geany/geany/pull/2181/commits/1fa5f66b2f2dd772a2cb5c6b5010bc19ce3bb824.

I will squash the latest commits and merge then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2181#discussion_r296209145
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190621/28d520cd/attachment-0001.html>