<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2181#discussion_r296209145">scripts/update-nsis-functions.sh</a>:</p>
<pre style='color:#555'>> @@ -39,8 +39,7 @@ variables=$(\
 variables_extra='{nsisdir} 0 1 2 3 4 5 6 7 8 9 r0 r1 r2 r3 r4 r5 r6 r7 r8 r9 \\n \\r \\t $'
 variables="${variables_extra} ${variables}"
 # prefix each element with a dollar sign
-declare -a variables_array=(${variables})
-variables="${variables_array[@]/#/'$'}"
+variables="$(echo $variables | sed 's/[^ ]*/$&/g')"
</pre>
<p>There were, of course.<br>
Removed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/1fa5f66b2f2dd772a2cb5c6b5010bc19ce3bb824/hovercard" href="https://github.com/geany/geany/commit/1fa5f66b2f2dd772a2cb5c6b5010bc19ce3bb824"><tt>1fa5f66</tt></a>.</p>
<p>I will squash the latest commits and merge then.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2181?email_source=notifications&email_token=AAIOWJ37DFNAJSUE3N62CIDP3TAMFA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4IUA5I#discussion_r296209145">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4AVM4WC7ZIG5ALP2DP3TAMFANCNFSM4HWTGO5Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3X65K3VIV3Y3A7YRTP3TAMFA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4IUA5I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ37DFNAJSUE3N62CIDP3TAMFA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4IUA5I#discussion_r296209145",
"url": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ37DFNAJSUE3N62CIDP3TAMFA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4IUA5I#discussion_r296209145",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>