[Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

[js361014]

@elextr
>To just come into a project and say "here, this is the way it should be done, throw away your existing features" is not the way to get engagement in a diverse group of contributors. 

At first step I posted a screenshot waiting for opinions from contributors. I feel @kugel- and @b4n supported my idea of search bar. Moreover, I modified my original code so that user can chose from 3 options: search bar on top, search bar at bottom and an old search dialog. I feel you used a straw man argument.

>like expanding the toolbar search facility instead of using space in the editor, which you havn't addressed yet

I guess it would be a long discussion on what should be in a toolbar, which of toolbar thinks should be provided as plugins etc. I felt that after @kugel- explanation
>The search bar comes and goes, the toolbar and statusbar are static. Sidebar and message window (on the right in my case) jumping around is distracting. I see that the search bar is part of the editor just like the header bar (when files change externally).

there is no need to elaborate.

>You need to make a case, and just saying "its the way browsers do it" isn't particularly persuasive when talking about an IDE.

I provided some arguments for search bar in https://github.com/geany/geany/pull/2220#issuecomment-512686843 and  @codebrainz said
>I don't disagree with the search bar vs search dialog (for most cases)

so I thought that's enough.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#issuecomment-515918471
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190729/b90fc700/attachment.html>