<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a></p>
<blockquote>
<p>To just come into a project and say "here, this is the way it should be done, throw away your existing features" is not the way to get engagement in a diverse group of contributors.</p>
</blockquote>
<p>At first step I posted a screenshot waiting for opinions from contributors. I feel <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=564520" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> and <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> supported my idea of search bar. Moreover, I modified my original code so that user can chose from 3 options: search bar on top, search bar at bottom and an old search dialog. I feel you used a straw man argument.</p>
<blockquote>
<p>like expanding the toolbar search facility instead of using space in the editor, which you havn't addressed yet</p>
</blockquote>
<p>I guess it would be a long discussion on what should be in a toolbar, which of toolbar thinks should be provided as plugins etc. I felt that after <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=564520" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> explanation</p>
<blockquote>
<p>The search bar comes and goes, the toolbar and statusbar are static. Sidebar and message window (on the right in my case) jumping around is distracting. I see that the search bar is part of the editor just like the header bar (when files change externally).</p>
</blockquote>
<p>there is no need to elaborate.</p>
<blockquote>
<p>You need to make a case, and just saying "its the way browsers do it" isn't particularly persuasive when talking about an IDE.</p>
</blockquote>
<p>I provided some arguments for search bar in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="468964732" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/2220" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2220/hovercard?comment_id=512686843&comment_type=issue_comment" href="https://github.com/geany/geany/pull/2220#issuecomment-512686843">#2220 (comment)</a> and  <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=181177" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a> said</p>
<blockquote>
<p>I don't disagree with the search bar vs search dialog (for most cases)</p>
</blockquote>
<p>so I thought that's enough.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2220?email_source=notifications&email_token=AAIOWJ22DZVYEXUZDOXMZBLQB22CTA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AEVBY#issuecomment-515918471">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ42G7TALL3VVABLI4LQB22CTANCNFSM4IEKN7DQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZYHUETTWR7SBEN7KLQB22CTA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AEVBY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJ22DZVYEXUZDOXMZBLQB22CTA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AEVBY#issuecomment-515918471",
"url": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJ22DZVYEXUZDOXMZBLQB22CTA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AEVBY#issuecomment-515918471",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>