[Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

[js361014]

@kugel- 
>I dislike that, while space-efficient, it looks too crammed. Some spacing is needed. Also it doesn't scale down well to small window sizes.

Can you reply to https://github.com/geany/geany/pull/2220#issuecomment-516101248 and https://github.com/geany/geany/pull/2220#issuecomment-516141984 ?

>mark-as-you-type is really nice but it bloats the diff currently. Chances for merging the general feature are better if it has parity with the dialog, and new features are added separately (and also to the dialog)

Currently, the dialog can be used to both search in current document and in whole session. Mark-as-you-type would make more sense if searching in whole session was moved for example into find in files dialog.

>The bar UI is completely C coded, this should be in glade as much as possible

I'm not a glade expert, but I guess this would require using separate glade file for search bar and doing something like https://stackoverflow.com/a/48569994

>hacking this into notebook.c is still the wrong way. this should live in search.c with the dialog, for the rest it ought to be transparent

I guess building/loading and adding search bar into new tab have to be done in notebook.c. The rest can be moved into search.c

>the custom widget is IMO not the right way. There is GtkInfoBar which seems more useful, shares lots of API with dialogs (so it helps maintaining common parts between dialog and bar) and has a less crammed appearance.

I'll check it out.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#issuecomment-526526330
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190830/e629b171/attachment.html>