[Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

[Thomas Martitz]

kugel- requested changes on this pull request.

I finally found time to give this a try again.

What I like is that the search bar doesn't use much space, and the "mark-as-you-type" feature that gives direct feedback to what you type.

I dislike that, while space-efficient, it looks too crammed. Some spacing is needed. Also it doesn't scale down well to small window sizes.

But it's definitely something I'd like to use over the dialog for everyday usage.

But the code is unacceptable in its current form I'm afraid.
- mark-as-you-type is really nice but it bloats the diff currently. Chances for merging the general feature are better if it has parity with the dialog, and new features are added separately (and also to the dialog)
- The bar UI is completely C coded, this should be in glade as much as possible
- hacking this into notebook.c is still the wrong way. this should live in search.c with the dialog, for the rest it ought to be transparent
- the custom widget is IMO not the right way. There is GtkInfoBar which seems more useful, shares lots of API with dialogs (so it helps maintaining common parts between dialog and bar) and has a less crammed appearance.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#pullrequestreview-281890051
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190830/18bfd0d3/attachment-0001.html>