[Github-comments] [geany/geany] Add new upstream candidate Flex parser (#2134)

Colomban Wendling notifications at xxxxx
Sat Apr 27 19:03:22 UTC 2019


> Disapproving it would mean I'd have to explain "why" which would mean I'd have to understand what the parser does and what it does wrong :-)

Oh you wouldn't have to go very far to find something wrong with that parser.  First thing, it's a fork of the jscript parser, which is wrong on its own.  Secondly, support for an XML dialect was thrown in there, well, let's say, quickly.  And if you're still standing and keep digging, you'll see that what's left is not *so* bad (well, not worse than jscript), but doesn't extract much info (no signature, no inheritance, no type, etc.).

This said, it still should work OK, and give somewhat better results than the previous one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2134#issuecomment-487311396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190427/69594ff9/attachment.html>


More information about the Github-comments mailing list