<blockquote>
<p>Disapproving it would mean I'd have to explain "why" which would mean I'd have to understand what the parser does and what it does wrong :-)</p>
</blockquote>
<p>Oh you wouldn't have to go very far to find something wrong with that parser.  First thing, it's a fork of the jscript parser, which is wrong on its own.  Secondly, support for an XML dialect was thrown in there, well, let's say, quickly.  And if you're still standing and keep digging, you'll see that what's left is not <em>so</em> bad (well, not worse than jscript), but doesn't extract much info (no signature, no inheritance, no type, etc.).</p>
<p>This said, it still should work OK, and give somewhat better results than the previous one.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2134#issuecomment-487311396">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5WLJLEWMUXOKXNXSDPSSPPVANCNFSM4HI4GLHQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3UFBB6TBUNHE676ULPSSPPVANCNFSM4HI4GLHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #2134: \u003e Disapproving it would mean I'd have to explain \"why\" which would mean I'd have to understand what the parser does and what it does wrong :-)\r\n\r\nOh you wouldn't have to go very far to find something wrong with that parser.  First thing, it's a fork of the jscript parser, which is wrong on its own.  Secondly, support for an XML dialect was thrown in there, well, let's say, quickly.  And if you're still standing and keep digging, you'll see that what's left is not *so* bad (well, not worse than jscript), but doesn't extract much info (no signature, no inheritance, no type, etc.).\r\n\r\nThis said, it still should work OK, and give somewhat better results than the previous one."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2134#issuecomment-487311396"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2134#issuecomment-487311396",
"url": "https://github.com/geany/geany/pull/2134#issuecomment-487311396",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>