[Github-comments] [geany/geany] Consume closing brackets, braces, parenthesis, single and double quotes (#2122)

[elextr]

elextr requested changes on this pull request.

Please update the manual as well.

Did you use glade 3.8.5/6 to update geany.glade?

> @@ -49,6 +49,7 @@ typedef sptr_t (*SciFnDirect)(sptr_t ptr, unsigned int iMessage, uptr_t wParam,
 #define SCI_CHANGEINSERTION 2672
 #define SCI_CLEARALL 2004
 #define SCI_DELETERANGE 2645
+#define SCI_DELETECHAR 2719

Anything in the scintilla directory comes from upstream, it will be overwritten next time its updated from upstream, so you need to get the changes into upstream.

>  		return 0;
+	
+	case SCI_DELETECHAR:
+		pdoc->DelChar(static_cast<Sci::Position>(wParam));
 

Also from upstream.

> @@ -227,6 +227,15 @@ void sci_add_text(ScintillaObject *sci, const gchar *text)
 	}
 }
 
+void sci_delete_char(ScintillaObject *sci, const gint pos)
+{
+	SSM(sci, SCI_DELETECHAR, pos, 0);

why did you add this? Why not just use DELETERANGE with length 1?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2122#pullrequestreview-225527951
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190411/5b32768f/attachment.html>