<p><b>@elextr</b> requested changes on this pull request.</p>

<p>Please update the manual as well.</p>
<p>Did you use glade 3.8.5/6 to update geany.glade?</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2122#discussion_r274417168">scintilla/include/Scintilla.h</a>:</p>
<pre style='color:#555'>> @@ -49,6 +49,7 @@ typedef sptr_t (*SciFnDirect)(sptr_t ptr, unsigned int iMessage, uptr_t wParam,
 #define SCI_CHANGEINSERTION 2672
 #define SCI_CLEARALL 2004
 #define SCI_DELETERANGE 2645
+#define SCI_DELETECHAR 2719
</pre>
<p>Anything in the scintilla directory comes from upstream, it will be overwritten next time its updated from upstream, so you need to get the changes into upstream.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2122#discussion_r274417341">scintilla/src/Editor.cxx</a>:</p>
<pre style='color:#555'>>              return 0;
+       
+       case SCI_DELETECHAR:
+               pdoc->DelChar(static_cast<Sci::Position>(wParam));
 
</pre>
<p>Also from upstream.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2122#discussion_r274420401">src/sciwrappers.c</a>:</p>
<pre style='color:#555'>> @@ -227,6 +227,15 @@ void sci_add_text(ScintillaObject *sci, const gchar *text)
        }
 }
 
+void sci_delete_char(ScintillaObject *sci, const gint pos)
+{
+       SSM(sci, SCI_DELETECHAR, pos, 0);
</pre>
<p>why did you add this? Why not just use DELETERANGE with length 1?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2122#pullrequestreview-225527951">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6gFuAXBg_hdYocAElSZIdXZNm0-ks5vfzjrgaJpZM4cpiw3">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ_ZJZ2HKjiZ5nu2Ammd_HgoMJxUJks5vfzjrgaJpZM4cpiw3.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr requested changes on #2122"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2122#pullrequestreview-225527951"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2122#pullrequestreview-225527951",
"url": "https://github.com/geany/geany/pull/2122#pullrequestreview-225527951",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>