[Github-comments] [geany/geany] Make geany -g tags output reproducible (#1989)

elextr notifications at xxxxx
Tue Nov 6 20:43:31 UTC 2018


elextr commented on this pull request.



> @@ -477,7 +460,7 @@ static GList *lookup_includes(const gchar **includes, gint includes_count)
 	size_t idx_glob;
 #endif
 
-	table = g_hash_table_new_full(tm_file_inode_hash, g_direct_equal, NULL, g_free);
+	table = g_hash_table_new_full(g_str_hash, g_direct_equal, NULL, g_free);

It does in fact matter, the key is a newly copied string, and you need to compare the strings, not the pointers to the strings so `g_str_equal` is right.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1989#discussion_r231284327
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181106/7d26f778/attachment.html>


More information about the Github-comments mailing list