<p><b>@elextr</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1989#discussion_r231284327">src/tagmanager/tm_workspace.c</a>:</p>
<pre style='color:#555'>> @@ -477,7 +460,7 @@ static GList *lookup_includes(const gchar **includes, gint includes_count)
        size_t idx_glob;
 #endif
 
-       table = g_hash_table_new_full(tm_file_inode_hash, g_direct_equal, NULL, g_free);
+       table = g_hash_table_new_full(g_str_hash, g_direct_equal, NULL, g_free);
</pre>
<p>It does in fact matter, the key is a newly copied string, and you need to compare the strings, not the pointers to the strings so <code>g_str_equal</code> is right.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1989#discussion_r231284327">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0Qbfd_cB89G926Y9wH3Z2Rn6Fbaks5usfRzgaJpZM4YQS08">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJydg2VbGuf9s5TeQvGzlm8w7Oc8lks5usfRzgaJpZM4YQS08.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr commented on #1989"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1989#discussion_r231284327"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1989#discussion_r231284327",
"url": "https://github.com/geany/geany/pull/1989#discussion_r231284327",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@elextr commented on 1989",
"sections": [
{
"text": "",
"activityTitle": "**elextr**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@elextr",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1989#discussion_r231284327"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406924604\n}"
}
],
"themeColor": "26292E"
}
]</script>