[Github-comments] [geany/geany-plugins] Revert "Port both webhelper and markdown to webkit2gtk" (#749)

[Matthew Brush]

> so it might be slightly annoying for that other Markdown PR

Not sure if I'm just confused, but wasn't it already merged? I honestly thought this revert had already happened as I checked the diff and #746 and #677 had no differences, so I didn't think it would be meaningful to merge until this revert happened.

> Also, for WebHelper I don't really mind so long as the small problems gets fixed; I wanted to keep GTK2 support

That was my issue with the Markdown changes, and it was somewhat fixed in follow ups, though I'd like to improve it to still [support all of the versions of webkit](https://github.com/geany/geany-plugins/pull/746#pullrequestreview-121957556) it's known to work with (the versions/package names are confusing but I guess `webkit-1.0`, `webkitgtk-3.0`, and `webkit2gtk-4.0`).

> it'd be just fine for me to work on a new PR if this is reverted

IMO this is the best way, #677 should have never been made to change two plugins at once (especially plugins with different maintainers), I think that's where a lot of the confusion/problems came from. Maybe in the future we should just decline PRs which affect multiple plugins unless it's related to translations or build system or other more global stuff like that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180603/c8d29910/attachment.html>