<blockquote>
<p>so it might be slightly annoying for that other Markdown PR</p>
</blockquote>
<p>Not sure if I'm just confused, but wasn't it already merged? I honestly thought this revert had already happened as I checked the diff and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="325068913" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany-plugins/issues/746" href="https://github.com/geany/geany-plugins/pull/746">#746</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="289361558" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany-plugins/issues/677" href="https://github.com/geany/geany-plugins/pull/677">#677</a> had no differences, so I didn't think it would be meaningful to merge until this revert happened.</p>
<blockquote>
<p>Also, for WebHelper I don't really mind so long as the small problems gets fixed; I wanted to keep GTK2 support</p>
</blockquote>
<p>That was my issue with the Markdown changes, and it was somewhat fixed in follow ups, though I'd like to improve it to still <a href="https://github.com/geany/geany-plugins/pull/746#pullrequestreview-121957556">support all of the versions of webkit</a> it's known to work with (the versions/package names are confusing but I guess <code>webkit-1.0</code>, <code>webkitgtk-3.0</code>, and <code>webkit2gtk-4.0</code>).</p>
<blockquote>
<p>it'd be just fine for me to work on a new PR if this is reverted</p>
</blockquote>
<p>IMO this is the best way, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="289361558" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany-plugins/issues/677" href="https://github.com/geany/geany-plugins/pull/677">#677</a> should have never been made to change two plugins at once (especially plugins with different maintainers), I think that's where a lot of the confusion/problems came from. Maybe in the future we should just decline PRs which affect multiple plugins unless it's related to translations or build system or other more global stuff like that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5z6uDbdLEKneVJ-lUNgAJlEY1xmks5t5DswgaJpZM4UX-IW">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJzrncJ0xTxIMdGdJCGWq9fah0STTks5t5DswgaJpZM4UX-IW.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818","url":"https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #749: \u003e so it might be slightly annoying for that other Markdown PR\r\n\r\nNot sure if I'm just confused, but wasn't it already merged? I honestly thought this revert had already happened as I checked the diff and #746 and #677 had no differences, so I didn't think it would be meaningful to merge until this revert happened.\r\n\r\n\u003e Also, for WebHelper I don't really mind so long as the small problems gets fixed; I wanted to keep GTK2 support\r\n\r\nThat was my issue with the Markdown changes, and it was somewhat fixed in follow ups, though I'd like to improve it to still [support all of the versions of webkit](https://github.com/geany/geany-plugins/pull/746#pullrequestreview-121957556) it's known to work with (the versions/package names are confusing but I guess `webkit-1.0`, `webkitgtk-3.0`, and `webkit2gtk-4.0`).\r\n\r\n\u003e it'd be just fine for me to work on a new PR if this is reverted\r\n\r\nIMO this is the best way, #677 should have never been made to change two plugins at once (especially plugins with different maintainers), I think that's where a lot of the confusion/problems came from. Maybe in the future we should just decline PRs which affect multiple plugins unless it's related to translations or build system or other more global stuff like that."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [geany/geany-plugins] Revert \"Port both webhelper and markdown to webkit2gtk\" (#749)",
"sections": [
{
"text": "",
"activityTitle": "**Matthew Brush**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@codebrainz",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 749,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"pullRequestId\": 749\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/749#issuecomment-394185818"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 341828118\n}"
}
],
"themeColor": "26292E"
}</script>