[Github-comments] [geany/geany] Remember search history (#1666) (#1745)

Colomban Wendling notifications at xxxxx
Wed Jan 24 19:58:18 UTC 2018


b4n commented on this pull request.



> +	g_strfreev(*recent_terms);
+
+	if (count == 0)
+	{
+		*recent_terms = NULL;
+		return;
+	}
+
+	*recent_terms = g_new0(gchar*, count + 1);
+
+	if (gtk_tree_model_get_iter_first(model, &iter))
+	{
+		do
+		{
+			gtk_tree_model_get(model, &iter, 0, &combo_text, -1);
+			if (*combo_text != 0)

Why not saving empty elements?  It would make a lot of sense for replacement strings: it's totally reasonable to replace with an empty string to remove the searched pattern.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1745#pullrequestreview-91310608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180124/f70b5355/attachment.html>


More information about the Github-comments mailing list