<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1745#discussion_r163661167">src/search.c</a>:</p>
<pre style='color:#555'>> +    g_strfreev(*recent_terms);
+
+       if (count == 0)
+       {
+               *recent_terms = NULL;
+               return;
+       }
+
+       *recent_terms = g_new0(gchar*, count + 1);
+
+       if (gtk_tree_model_get_iter_first(model, &iter))
+       {
+               do
+               {
+                       gtk_tree_model_get(model, &iter, 0, &combo_text, -1);
+                       if (*combo_text != 0)
</pre>
<p>Why not saving empty elements?  It would make a lot of sense for replacement strings: it's totally reasonable to replace with an empty string to remove the searched pattern.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1745#pullrequestreview-91310608">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJz6eJDz5idi_voK1abNFCTmC-F8Eks5tN4tagaJpZM4Rk8q8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ9mb3dgT9WG7oUzqgO3Y6IC_fn7hks5tN4tagaJpZM4Rk8q8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1745#pullrequestreview-91310608"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1745"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1745#pullrequestreview-91310608"}}}</script>