[Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

[Jiří Techet]

Sorry, hoped to work on this earlier but didn't have time in the last two days (will address the issues hopefully today).

> @b4n @techee I used the asciidoc.c from upstream ctags on top of this PR (and changed the map_ASCIIDOC in tm_parser.c to match) IT WORKS!!!! 🥇 😀

Cool! If it's the case (I haven't checked yet), I'd suggest using the upstream versions and if there's a better way to implement this, then we could go the (hopefully new standard) "implement in uctags, import to Geany" way. @b4n What do you think?

> So all we have to do is merge this quickly and import the upstream 😄 (well and @b4n make the change to tm_parser.c properly).

And even more cool thing is having @elextr excited to get this merged into Geany soon :-).

@b4n Is it necessary to have a separate fix for master if it gets fixed in this branch? Master is mildly broken because of this now but it's not something super-critical like a crash and I think it could wait until this pull request is merged.

> why the TxtToTags cases are removed? or t2t isn't Txt2Tags?

Ah, OK, the test got broken and without checking I somehow assumed it was Actionscript. Seems there's a problem with scope separators in this test - I'll look into this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2018#issuecomment-449084804
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181220/993232df/attachment-0001.html>